Skip to content

Diagnostic tweaks #18840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Diagnostic tweaks #18840

wants to merge 4 commits into from

Conversation

huonw
Copy link
Member

@huonw huonw commented Nov 10, 2014

Fix some old papercuts with diagnostics, e.g. tweaking spans, rewording messages. See individual commits.

@huonw
Copy link
Member Author

huonw commented Nov 10, 2014

This fails make tidy with (among other things):

.../compile-fail/trailing-carriage-return-in-string.rs:18: CR character

Any suggestions? The test is designed to a have CR in it.

@alexcrichton
Copy link
Member

I think the // ignore-tidy-cr directive will take care of that tidy lint. You may also want to add the file to src/test/run-pass/.gitattributes (or start a new one for the compile-fail directory).

@alexcrichton
Copy link
Member

Thanks @huonw! r=me with just a few nits

huonw added 3 commits November 13, 2014 13:43
@huonw
Add error message specific to \<carriage return>.
e621e32 
This can crop-up with a misconfigured editor or an unexpected
interaction between version control and certain operating systems.

Closes rust-lang#11669.
@huonw
Add more "help: ..."'s to the parser.
26282ac 
Adds a method for printing a fatal error and also a help message to the
parser and uses this in a variety of places to improve error messages.

Closes rust-lang#12213.
@huonw
Use the correct span for out-of-range int literals.
661598c 
This corrects the error message to point at the literal, not the next
token.

Closes rust-lang#17123.
bors added a commit that referenced this pull request Nov 14, 2014
@bors
auto merge of #18840 : huonw/rust/tweaks, r=alexcrichton
bb2168c 
Fix some old papercuts with diagnostics, e.g. tweaking spans, rewording messages. See individual commits.
@bors bors closed this Nov 14, 2014
@huonw huonw deleted the tweaks branch November 14, 2014 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huonw @alexcrichton @bors